Ticket #1405: dhcp_hostname_option.patch

cpukit/libnetworking/rtems/rtems_dhcp.c

@@ -712 +712 @@
   {
     if (gethostname (hostname, MAXHOSTNAMELEN) == 0)
     {
-      call->vend[len++] = DHCP_HOST;
-      call->vend[len++] = strlen (hostname);
-      strcpy ((char*) &call->vend[len], hostname);
-      len += strlen (hostname);
+      /* RFC 2132 Section 3.14. dictates min length for this option is 1 char.
+         If hostname is zero-length, then let's just not add it */
+
+      int hostnamelen = strlen(hostname);
+
+      if( (hostnamelen > 0) && (hostnamelen < 256) )
+      {
+        call->vend[len++] = DHCP_HOST;
+        call->vend[len++] = (uint8_t) hostnamelen;
+        strcpy ((char*) &call->vend[len], hostname);
+        len += hostnamelen;
+      }
     }
     free (hostname, 0);
   }