#4694 closed defect (invalid)

sptests/sp37 fails to compile if RTEMS_SMP is not defined

Reported by: Lucian-Raul Silistru Owned by: joel@…
Priority: normal Milestone: 6.1
Component: test Version: 6
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

Issue seems to be caused by lines 191-193 and 207 in testsuites/sptests/sp37/init.c

  • name is undefined
  • _ISR_lock_Initialize is "(void)name"

In file included from ../../../../../../RTEMS/cpukit/include/rtems/rtems/intr.h:70,

from ../../../../../../RTEMS/cpukit/include/rtems.h:69,
from ../../../../../../RTEMS/bsps/include/bsp/default-initial-extension.h:40,
from ../../../../../../RTEMS/bsps/myriad2/ma2x8x/include/bsp.h:27,
from ../../../../../../RTEMS/testsuites/support/include/tmacros.h:41,
from ../../../../../../RTEMS/testsuites/sptests/sp37/system.h:35,
from ../../../../../../RTEMS/testsuites/sptests/sp37/init.c:41:

../../../../../../RTEMS/testsuites/sptests/sp37/init.c: In function 'test_isr_locks':
../../../../../../RTEMS/testsuites/sptests/sp37/init.c:207:42: error: 'name' undeclared (first use in this function)

207 | _ISR_lock_Initialize( &container.lock, name );

| ~

../../../../../../RTEMS/cpukit/include/rtems/score/isrlock.h:202:12: note: in definition of macro '_ISR_lock_Initialize'

202 | (void) _name

|

../../../../../../RTEMS/testsuites/sptests/sp37/init.c:207:42: note: each undeclared identifier is reported only once for each function it appears in

207 | _ISR_lock_Initialize( &container.lock, name );

| ~

../../../../../../RTEMS/cpukit/include/rtems/score/isrlock.h:202:12: note: in definition of macro '_ISR_lock_Initialize'

202 | (void) _name

|

Change History (3)

comment:1 Changed on 08/02/22 at 17:51:36 by Joel Sherrill

This report appears to be against an architecture and BSP (myriad2/ma2x8x) that are not in the RTEMS.org source base. I have built two other non-SMP BSPs this week (mips and powerpc) and the weekly BSP build sweeps would also catch a general or BSP specific build issue.

The ISR method definitions are part of the architecture port. My guess is that you are dropping the architecture and BSP code into a git clone from rtems.org and that the myriad2/ma2x8x code is not up to date.

comment:2 Changed on 08/03/22 at 16:05:16 by Lucian-Raul Silistru

Thanks for confirmation that it should work.

Figured it was cherrypick from an older version that broke it for us. Once removed we don't see the issue anymore.

comment:3 Changed on 08/08/22 at 09:59:01 by Lucian-Raul Silistru

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.