#4666 closed enhancement (fixed)

TFTP: Implement block and window size options

Reported by: Sebastian Huber Owned by: Sebastian Huber
Priority: normal Milestone: 6.1
Component: fs Version: 6
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

Support the following TFTP options:

  • RFC 2347 TFTP Option Extension
  • RFC 2348 TFTP Blocksize Option
  • RFC 7440 TFTP Windowsize Option

Change History (10)

comment:1 Changed on 06/21/22 at 07:46:13 by Frank Kühndel <frank.kuehndel@…>

In c044f050/rtems:

TFTPFS: Cleanup: Remove spaces at lines ends

Update #4666.

comment:2 Changed on 06/21/22 at 07:46:16 by Frank Kühndel <frank.kuehndel@…>

In 679e7f10/rtems:

TFTPFS: Implement block and window size options

The original file cpukit/libfs/src/ftpfs/tftpDriver.c
is split into two:

tftpfs.c - This file contains the code from tftpDriver.c

related to file system operations such as mount(),
open(), read(), and so on.

tftpDriver.c - In the original file remains only the code related

to networking. This code implements the Trivial
File Transfer Protocol (TFTP).

Moreover, the code is extended to support

  • RFC 2347 TFTP Option Extension
  • RFC 2348 TFTP Blocksize Option
  • RFC 7440 TFTP Windowsize Option

Update #4666.

comment:3 Changed on 06/21/22 at 07:46:18 by Frank Kühndel <frank.kuehndel@…>

In 3e2b4ec/rtems:

TFTPFS: Add tests

Update #4666.

comment:4 Changed on 06/21/22 at 14:06:17 by Sebastian Huber <sebastian.huber@…>

In e38d4f7/rtems:

TFTPFS: Reduce test configuration

Update #4666.

comment:5 Changed on 06/21/22 at 14:06:19 by Sebastian Huber <sebastian.huber@…>

In 085f363/rtems:

TFTPFS: Fix test configuration for FP targets

The test uses snprintf().

Update #4666.

comment:6 Changed on 11/29/22 at 22:50:21 by Chris Johns

Has this task been completed?

comment:7 Changed on 02/10/23 at 13:51:58 by Joel Sherrill

Pinging again. Has this task been completed? If so, please close. If not, will it be done by 6.1?

comment:8 Changed on 02/27/23 at 16:21:32 by Frank Kuehndel

All three RFCs have been implemented and the tests are also present and working. One additional patch was needed to provide a missing diagram for the documentation:

https://lists.rtems.org/pipermail/devel/2022-October/073561.html

Moreover, Coverity issues were fixed later on, see #4718.

This work on TFTP is completed and this ticket can be closed.

comment:9 Changed on 02/27/23 at 16:22:47 by Frank Kuehndel

Resolution: fixed
Status: assignedclosed

comment:10 Changed on 01/18/24 at 16:36:42 by Sebastian Huber <sebastian.huber@…>

In 3626fe8/rtems:

fstests/tftpfs: Fix build dependency

Update #4666.

Note: See TracTickets for help on using tickets.