Opened on 04/07/21 at 13:01:01

Last modified on 12/16/21 at 16:42:18

#4381 new defect

crypt-sha256.c: Constant variable guards dead code

Reported by: Ryan Long Owned by:
Priority: normal Milestone: Indefinite
Component: lib Version: 6
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

CID 1018089: Constant variable guards dead code in crypt_sha256_r().

   assignment: Assigning: copied_salt = NULL.
 77        copied_salt = NULL;
.
.
.
   null: At condition copied_salt != NULL, the value of copied_salt must be NULL.
   dead_error_condition: The condition copied_salt != NULL cannot be true.
265        if (copied_salt != NULL)
   CID 1018089 (#1 of 1): 'Constant' variable guards dead code (DEADCODE)dead_error_line: Execution cannot reach this statement: memset(copied_salt, 0, salt....

CID 1018090: Constant variable guards dead code in crypt_sha256_r().

   assignment: Assigning: copied_key = NULL.
 76        copied_key = NULL;
.
.
.
   null: At condition copied_key != NULL, the value of copied_key must be NULL.
   dead_error_condition: The condition copied_key != NULL cannot be true.
263        if (copied_key != NULL)
   CID 1018090 (#1 of 1): 'Constant' variable guards dead code (DEADCODE)dead_error_line: Execution cannot reach this statement: memset(copied_key, 0, key_l....

Change History (2)

comment:1 Changed on 04/07/21 at 13:02:48 by Ryan Long

These variables are no longer in the code according to the latest stable version of freeBSD. ​https://cgit.freebsd.org/src/tree/lib/libcrypt/crypt-sha256.c?h=stable/13#n71

Last edited on 04/07/21 at 13:03:33 by Ryan Long (previous) (diff)

comment:2 Changed on 12/16/21 at 16:42:18 by Ryan Long

Milestone: 6.1 → Indefinite
Note: See TracTickets for help on using tickets.