Opened on 03/31/21 at 03:26:34

Closed on 04/01/21 at 17:43:50

#4368 closed defect (fixed)

rtems--tools tool kit temp file constructor does nothing

Reported by: Chris Johns Owned by: Joel Sherrill
Priority: normal Milestone: 6.1
Component: tool Version: 6
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

A change to add an overloaded constructor ...

​https://git.rtems.org/rtems-tools/commit/?id=420d7a13672991a1480d06ac02190f2976b9253b

does not do anything. The body of the constructor is empty.

Thinking about this I think the change is not right because the code depends on libiberty make temp call to find the temp directory and that is designed to crate safe temp files.

I am now wondering how the code was tested? The files registered are not known to the clean up handler that runs on exit.

Change History (1)

comment:1 Changed on 04/01/21 at 17:43:50 by Alex White

Resolution: → fixed
Status: assigned → closed

This patch set up the interfaces used in the "covoar: Add option to create named objdumps" patch that I sent. We determined that patch was not needed given its hacked-togetherness along with future speedups that we had in mind which would make it obsolete anyway.

This patch should have been removed from the set to be committed, but I forgot to send out a notice to exclude it. Sorry for the confusion.

This commit should be reverted.

Note: See TracTickets for help on using tickets.