Reserved identifier "time" re-used in rtems_clock_get_tod_timeval()

[Jens Schweikhardt]

The ISO C identifier "time" from time.h is re-used in the prototype and definition of the rtems_clock_get_tod_timeval() function (and maybe elsewhere too).
In certain cases this could lead to undefined behavior.
It certainly upsets our lint (Gimpel FlexeLint?).
It's good software hygiene to avoid shadowing ISO C identifiers.
Desired change: in cpukit/rtems/src/clockgettodtimeval.c
use an unreserved identifier.

[Jens Schweikhardt]

The header should also be fixed, cpukit/include/rtems/rtems/clock.h

[Joel Sherrill]

Could you please provide a patch for this? It seems like a reasonable and mostly benign change but will ripple to Doxygen and documentation. If you fix the code to make your Flexelint happy, then we can be sure it is really fixed.

[Jens Schweikhardt]

time-is-reserved

[Jens Schweikhardt]

I've attached a patch renaming time to the_time, also in doxygen comments.
I'm new to git and followed the instructions for patch creation but ran into a wall with git format-patch (no output anywhere I could find). So I used git diff. The commit message could be

Rename the reserved identifier "time" to "the_time" to not invade ISO C name space.

[Sebastian Huber <sebastian.huber@…>]

In dde74af/rtems:

rtems: Adjust parameter names

Adjust parameter names to match with the declaration. This avoid using
a name reserved by the C standard: "time".

Close #4035.