Opened on 04/21/18 at 08:25:44
Last modified on 04/21/18 at 15:11:06
#3405 assigned defect
src/bsps/sparc/shared/tmtc/grtc.c:1871]: (style) Suspicious condition
Reported by: | David Binderman | Owned by: | Daniel Hellstrom |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | admin | Version: | |
Severity: | normal | Keywords: | |
Cc: | Blocked By: | ||
Blocking: |
Description
src/bsps/sparc/shared/tmtc/grtc.c:1871]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
Source code is
while ( pDev->running && ((ret=process_dma(pDev) == 2) (ret == -1)) ) {
Maybe better code
while ( pDev->running && (((ret = process_dma(pDev)) == 2) (ret == -1)) ) {
Change History (1)
comment:1 Changed on 04/21/18 at 15:11:06 by Joel Sherrill
Owner: | set to Daniel Hellstrom |
---|---|
Status: | new → assigned |
Note: See
TracTickets for help on using
tickets.