#3122 closed enhancement (fixed)
Simplify and unify BSP_output_char
Reported by: | Sebastian Huber | Owned by: | Sebastian Huber |
---|---|---|---|
Priority: | normal | Milestone: | 5.1 |
Component: | bsps | Version: | 5 |
Severity: | normal | Keywords: | |
Cc: | Blocked By: | ||
Blocking: |
Description
The BSP_output_char should output a char and not mingle with high level processing, e.g. '\n' to '\r\n' translation. Move this translation to rtems_putc(). Remove it from all the BSP_output_char implementations.
Change History (10)
comment:1 Changed on 09/08/17 at 08:38:09 by Sebastian Huber
Status: | assigned → accepted |
---|
comment:2 follow-up: 3 Changed on 09/10/17 at 20:36:44 by Chris Johns
comment:3 Changed on 09/11/17 at 08:44:16 by Sebastian Huber
Replying to Chris Johns:
Is this an internal RTEMS function?
This is the function pointer used by rtems_putc() and printk().
Could this change any external code that may be using it?
What do users call to get the same thing as we currently have?
It is a good change, I am just considering the timing late in a release development cycle.
This is not an API change. Only the "\n" to "\r\n" moves from the lowest level one step up to rtems_putc().
comment:4 Changed on 09/11/17 at 08:45:15 by Sebastian Huber
comment:5 Changed on 09/12/17 at 08:01:16 by Sebastian Huber <sebastian.huber@…>
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
In 1bc0ad2/rtems:
comment:9 Changed on 11/09/17 at 06:27:14 by Sebastian Huber
Milestone: | 4.12.0 → 5.1 |
---|
Milestone renamed
Is this an internal RTEMS function?
Could this change any external code that may be using it?
What do users call to get the same thing as we currently have?
It is a good change, I am just considering the timing late in a release development cycle.