Opened on 08/08/16 at 06:07:01

Last modified on 01/23/17 at 07:15:42

#2773 assigned defect

c/src/lib/libcpu/sh/sh7032/clock/ckinit.c:210: possible bad expression ?

Reported by: David Binderman Owned by: Needs Funding
Priority: normal Milestone: Indefinite
Component: unspecified Version: 4.10
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

c/src/lib/libcpu/sh/sh7032/clock/ckinit.c:210]: (style) Expression '(X | 0xffff) > 0x0' is always true.

Source code is

if ( ( cclicks_per_tick | 0xffff ) > 0 )

Maybe

if ( ( cclicks_per_tick & 0xffff ) > 0 )

was intended ?

Change History (3)

comment:1 Changed on 01/20/17 at 14:17:01 by David Binderman

Still broken, some six months later.

comment:2 Changed on 01/20/17 at 14:30:51 by Sebastian Huber

sh support is unmaintained.

comment:3 Changed on 01/23/17 at 07:15:42 by Sebastian Huber

Milestone: 4.11.1 → Indefinite
Owner: set to Needs Funding
Status: new → assigned
Note: See TracTickets for help on using tickets.