Opened on 05/14/16 at 15:28:51
Last modified on 02/05/18 at 05:52:47
#2711 assigned defect
grtc.c:1840]: (style) Suspicious condition
Reported by: | David Binderman | Owned by: | Daniel Hellstrom |
---|---|---|---|
Priority: | normal | Milestone: | Indefinite |
Component: | unspecified | Version: | 4.11 |
Severity: | normal | Keywords: | |
Cc: | Blocked By: | ||
Blocking: |
Description
rtems/c/src/lib/libbsp/sparc/shared/tmtc/grtc.c:1840]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
Source code is
while ( pDev->running && ((ret=process_dma(pDev) == 2) (ret == -1)) ) {
Maybe better code
while ( pDev->running && (((ret = process_dma(pDev)) == 2) (ret == -1)) ) {
Change History (6)
comment:1 Changed on 01/20/17 at 15:19:10 by David Binderman
comment:2 Changed on 01/23/17 at 07:15:00 by Sebastian Huber
Owner: | set to Daniel Hellstrom |
---|---|
Status: | new → assigned |
comment:3 Changed on 01/26/17 at 07:16:00 by Sebastian Huber
Milestone: | 4.11.1 → 4.11.2 |
---|
comment:4 Changed on 03/23/17 at 01:03:28 by Chris Johns
Milestone: | 4.11.2 → 4.11.3 |
---|
The 4.11.2 milestone is closing.
comment:5 Changed on 03/23/17 at 01:05:42 by Chris Johns
Version: | 4.10 → 4.11 |
---|
Move to the 4.11 branch.
comment:6 Changed on 02/05/18 at 05:52:47 by Chris Johns
Milestone: | 4.11.3 → Indefinite |
---|
Note: See
TracTickets for help on using
tickets.
Still broken, over seven months later.