![[RTEMS Logo]](/images/logo.png){kind=logo}
Opened on 10/29/09 at 06:18:16
Closed on 11/29/22 at 21:49:38
#1459 closed defect (fixed)
Add rtems_shell_main_monitor to cpukit/libmisc/shell/shell.h?
| Reported by: | Ralf Corsepius | Owned by: | Chris Johns |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.1 |
| Component: | shell | Version: | 4.10 |
| Severity: | minor | Keywords: | |
| Cc: | chrisj@…, vattam.santosh@… | Blocked By: | |
| Blocking: |
Description (last modified by Chris Johns)
rtems_shell_main_monitor
is a private function of
cpukit/libmisc/shell/cmds.c
However, the way
testsuites/libtests/monitor02/init.c
uses it (as a public/exported function) to me reads as a strong indication that
rtems_shell_main_monitor()
should be "made public" by declaring/prototyping it in
cpukit/libmisc/shell/shell.h
Change History (6)
comment:1 Changed on 12/24/09 at 22:07:08 by Santosh Vattam
| Cc: | Santosh Vattam added |
|---|
comment:2 Changed on 12/25/09 at 14:29:03 by Joel Sherrill
| Owner: | changed from Joel Sherrill to Chris Johns |
|---|
comment:3 Changed on 05/15/10 at 06:42:03 by Chris Johns
| Milestone: | 4.10 → 4.11 |
|---|---|
| Status: | new → assigned |
comment:4 Changed on 11/23/14 at 17:37:06 by Joel Sherrill
| Description: | modified (diff) |
|---|---|
| Milestone: | 4.11 → 5.0 |
| Summary: | Add rtems_shell_main_monitor to cpukit/libmisc/shell/shell.h? → Make Monitor Commands first class citizens in shell, |
The monitor predates the shell. There is really no point in having two CLIs. The monitor commands are available in the shell but the integration is a hack. The monitor commands need to be made first class shell commands and the set for looking at objects enhanced to include more objects.
This may be a decent GSoC project.
comment:6 Changed on 11/29/22 at 21:49:38 by Chris Johns
| Description: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Fixed in 2011.
Note: See
TracTickets for help on using
tickets.
Exporting this interface from the shell is a hack as well. The central issue is the purpose of the monitor now we have a shell. Should we consume the monitor into the shell and remove the duplicate code in RTEMS ? The monitor has stdin handling, terminal handling plus help formatting (which is much better than the shell's). I think these can all be merged into the shell and the monitor goes away.
I think this should be moved to the 4.11 milestone, which I have done, and we live with the current code for 4.10.
Once issue this raises is the pressure on the shell with all the files that are starting to appear in it. Maybe the monitor command remain in its directory.